any remittance can be read by id - #1444
Open
bakarezainab wants to merge 4 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return { | ||
| ...old, | ||
| totalOwed: newOwed, | ||
| totalRepaid: newRepaid, |
| } | ||
|
|
||
| const [whole = "0", fraction = ""] = value.split("."); | ||
| const normalizedFraction = fraction.padEnd(decimals, "0").slice(0, decimals); |
| } | ||
|
|
||
| const [whole = "0", fraction = ""] = value.split("."); | ||
| const normalizedFraction = fraction.padEnd(decimals, "0").slice(0, decimals); |
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
you found a genuine live auth bypass (the tautological ownership checks in remittanceController), thank you. heads up though: #1578 fixes the same two tautologies with a minimal diff and is being merged now, so please rebase on current main first and see what is left. beyond that, this branch carries a lot of unrelated stale-base noise that cannot be merged:
- rebase onto current main and drop everything except the remittance controller changes still needed after #1578, your new remittanceController.test.ts (the sender/recipient/forbidden coverage is genuinely valuable and #1578 has no tests), and the security-issues.test.ts update. no package-lock, contract snapshots, indexer, gamification or transactionController changes.
- re-run CI after the rebase; the contracts red comes from the stale snapshots in this branch.
- consider retitling to make clear it adds the regression coverage for the read-by-id IDOR.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure your PR follows these steps, mirroring our
CONTRIBUTING.mdguidelines.CONTRIBUTING.mddocument.Closes #1374